Skip to content

mumble: 1.5.857 -> 1.6.870#495932

Draft
felixsinger wants to merge 2 commits intoNixOS:masterfrom
felixsinger:pkgs/mumble/update
Draft

mumble: 1.5.857 -> 1.6.870#495932
felixsinger wants to merge 2 commits intoNixOS:masterfrom
felixsinger:pkgs/mumble/update

Conversation

@felixsinger
Copy link
Member

@felixsinger felixsinger commented Mar 2, 2026 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Mar 2, 2026
@Hartmnt
Copy link

Hartmnt commented Mar 2, 2026 •
edited
Loading

Hi, we added https://github.com/mumble-voip/mumble/blob/master/docs/dev/build-instructions/cmake_options.md#use-timestamps to make reproducible builds a tiny bit nicer.

@felixsinger
Copy link
Member Author

felixsinger commented Mar 2, 2026

Hi, we added https://github.com/mumble-voip/mumble/blob/master/docs/dev/build-instructions/cmake_options.md#use-timestamps to make reproducible builds a tiny bit nicer.

Thank you for the hint! It seems Nix already uses 1980 for reproducibility, but the copyright notes looked a bit confusing this way. So I've added it :)

Copyright 2005-1980 The Mumble Developers

@felixsinger felixsinger force-pushed the pkgs/mumble/update branch 2 times, most recently from d26f246 to 5ee776b Compare March 2, 2026 21:47
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 2, 2026
felixsinger
felixsinger commented Mar 16, 2026
View reviewed changes
@felixsinger felixsinger requested a review from dwt March 16, 2026 09:59
dwt
dwt suggested changes Mar 16, 2026
View reviewed changes
Copy link
Contributor

@dwt dwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes per se look fine, but it seems that disabling compilation of the overlay for darwin is still required and currently missing.

@felixsinger felixsinger force-pushed the pkgs/mumble/update branch 2 times, most recently from 38fb19a to 55fb82e Compare March 16, 2026 18:49
@felixsinger
Copy link
Member Author

felixsinger commented Mar 16, 2026 •
edited
Loading

I've added some more options disabling bundled libraries. I couldn't disable bundled SOCI by using -D bundled-soci=OFF. I'm getting this error during the configure phase. Not sure what's wrong since soci was added to buildInputs.

CMake Error at src/database/CMakeLists.txt:80 (target_link_libraries):
  Target "mumble_database" links to:

    SOCI::soci

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

@felixsinger
Copy link
Member Author

felixsinger commented Mar 16, 2026

I've added some more options disabling bundled libraries. I couldn't disable bundled SOCI by using -D bundled-soci=OFF. I'm getting this error during the configure phase. Not sure what's wrong since soci was added to buildInputs.

Fixed it with mumble-voip/mumble#7122

@felixsinger felixsinger mentioned this pull request Mar 16, 2026
Open
@dwt
Copy link
Contributor

dwt commented Mar 17, 2026 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 495932
Commit: 691e7d878833607378390a34c15aa4379159c005

x86_64-darwin

❌ 1 package failed to build:
  • ioq3-scion
✅ 6 packages built:
  • ioquake3
  • mumble
  • quake3arena
  • quake3arena-hires
  • quake3demo
  • quake3demo-hires

aarch64-darwin

❌ 1 package failed to build:
  • ioq3-scion
✅ 6 packages built:
  • ioquake3
  • mumble
  • quake3arena
  • quake3arena-hires
  • quake3demo
  • quake3demo-hires
Error logs: `x86_64-darwin`
ioq3-scion 
      _Netchan_InitSession in net_chan.o
  "_sodium_base642bin", referenced from:
      _Netchan_InitSession in net_chan.o
  "_sodium_bin2base64", referenced from:
      _CL_CheckForResend in cl_main.o
      _SV_Init in sv_init.o
  "_sodium_increment", referenced from:
      _Netchan_SendEncrypted in net_chan.o
  "_sodium_init", referenced from:
      _main in sys_main.o
  "_sodium_memzero", referenced from:
      _CL_ConnectionlessPacket in cl_main.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Makefile:2447: build/release-darwin-x86_64/ioquake3.x86_64] Error 1
rm build/release-darwin-x86_64/renderergl2/glsl/calclevels4x_vp.c build/release-darwin-x86_64/renderergl2/glsl/fogpass_fp.c build/release-darwin-x86_64/renderergl2/glsl/calclevels4x_fp.c build/release-darwin-x86_64/renderergl2/glsl/dlight_fp.c build/release-darwin-x86_64/renderergl2/glsl/depthblur_fp.c build/release-darwin-x86_64/renderergl2/glsl/depthblur_vp.c build/release-darwin-x86_64/renderergl2/glsl/bokeh_vp.c build/release-darwin-x86_64/renderergl2/glsl/down4x_vp.c build/release-darwin-x86_64/renderergl2/glsl/down4x_fp.c build/release-darwin-x86_64/renderergl2/glsl/bokeh_fp.c build/release-darwin-x86_64/renderergl2/glsl/dlight_vp.c
make[2]: Leaving directory '/nix/var/nix/b/7vqdxrqy11bhdwp1pwcgx7g5z5/source'
make[1]: *** [Makefile:1639: targets] Error 2
make[1]: Leaving directory '/nix/var/nix/b/7vqdxrqy11bhdwp1pwcgx7g5z5/source'
make: *** [Makefile:1550: release] Error 2
Error logs: `aarch64-darwin`
ioq3-scion 
      _Netchan_InitSession in net_chan.o
  "_sodium_base642bin", referenced from:
      _Netchan_InitSession in net_chan.o
  "_sodium_bin2base64", referenced from:
      _CL_CheckForResend in cl_main.o
      _SV_Init in sv_init.o
  "_sodium_increment", referenced from:
      _Netchan_SendEncrypted in net_chan.o
  "_sodium_init", referenced from:
      _main in sys_main.o
  "_sodium_memzero", referenced from:
      _CL_ConnectionlessPacket in cl_main.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Makefile:2447: build/release-darwin-arm64/ioquake3.arm64] Error 1
rm build/release-darwin-arm64/renderergl2/glsl/bokeh_fp.c build/release-darwin-arm64/renderergl2/glsl/calclevels4x_fp.c build/release-darwin-arm64/renderergl2/glsl/down4x_fp.c build/release-darwin-arm64/renderergl2/glsl/depthblur_fp.c build/release-darwin-arm64/renderergl2/glsl/dlight_fp.c build/release-darwin-arm64/renderergl2/glsl/dlight_vp.c build/release-darwin-arm64/renderergl2/glsl/down4x_vp.c build/release-darwin-arm64/renderergl2/glsl/bokeh_vp.c build/release-darwin-arm64/renderergl2/glsl/depthblur_vp.c build/release-darwin-arm64/renderergl2/glsl/calclevels4x_vp.c build/release-darwin-arm64/renderergl2/glsl/fogpass_fp.c
make[2]: Leaving directory '/nix/var/nix/b/4wrs5q553q10s6sihi1dsfdamw/source'
make[1]: *** [Makefile:1639: targets] Error 2
make[1]: Leaving directory '/nix/var/nix/b/4wrs5q553q10s6sihi1dsfdamw/source'
make: *** [Makefile:1550: release] Error 2

the scion build apparently breaks all the time anyway, the mantainer told me not to worry - so I guess its ok? 🤗

@felixsinger
Copy link
Member Author

felixsinger commented Mar 17, 2026

the scion build apparently breaks all the time anyway, the mantainer told me not to worry - so I guess its ok?

Yeah, that broke before, but from your report it looks like it's broken on Darwin in general. Maybe we should mark it as broken or remove Darwin from supported architectures?

Anyway. Great, thank you 🙂

@dwt
Copy link
Contributor

dwt commented Mar 17, 2026

Yeah, that broke before, but from your report it looks like it's broken on Darwin in general. Maybe we should mark it as broken or remove Darwin from supported architectures?

I would give that to the maintainer - he asked me to abstain, when I last checked the package

@felixsinger
Copy link
Member Author

felixsinger commented Mar 17, 2026

Yeah, that broke before, but from your report it looks like it's broken on Darwin in general. Maybe we should mark it as broken or remove Darwin from supported architectures?

I would give that to the maintainer - he asked me to abstain, when I last checked the package

Okay. Well, I don't care that much. So I'm fine with either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dwt dwt dwt requested changes

@Hartmnt Hartmnt Hartmnt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felixsinger @Hartmnt @dwt